fixes and refactor
This commit is contained in:
@@ -2,21 +2,24 @@
|
||||
Support ticket API endpoints
|
||||
"""
|
||||
from typing import List, Optional
|
||||
from fastapi import APIRouter, Depends, HTTPException, status, Request
|
||||
from fastapi import APIRouter, Depends, HTTPException, status, Request, Query
|
||||
from sqlalchemy.orm import Session, joinedload
|
||||
from sqlalchemy import func, desc, and_, or_
|
||||
from datetime import datetime
|
||||
from datetime import datetime, timezone
|
||||
import secrets
|
||||
|
||||
from app.database.base import get_db
|
||||
from app.models import User, SupportTicket, TicketResponse as TicketResponseModel, TicketStatus, TicketPriority, TicketCategory
|
||||
from app.auth.security import get_current_user, get_admin_user
|
||||
from app.services.audit import audit_service
|
||||
from app.services.query_utils import apply_sorting, paginate_with_total, tokenized_ilike_filter
|
||||
from app.api.search_highlight import build_query_tokens
|
||||
|
||||
router = APIRouter()
|
||||
|
||||
# Pydantic models for API
|
||||
from pydantic import BaseModel, Field, EmailStr
|
||||
from pydantic.config import ConfigDict
|
||||
|
||||
|
||||
class TicketCreate(BaseModel):
|
||||
@@ -57,8 +60,7 @@ class TicketResponseOut(BaseModel):
|
||||
author_email: Optional[str]
|
||||
created_at: datetime
|
||||
|
||||
class Config:
|
||||
from_attributes = True
|
||||
model_config = ConfigDict(from_attributes=True)
|
||||
|
||||
|
||||
class TicketDetail(BaseModel):
|
||||
@@ -81,15 +83,19 @@ class TicketDetail(BaseModel):
|
||||
assigned_to: Optional[int]
|
||||
assigned_admin_name: Optional[str]
|
||||
submitter_name: Optional[str]
|
||||
responses: List[TicketResponseOut] = []
|
||||
responses: List[TicketResponseOut] = Field(default_factory=list)
|
||||
|
||||
class Config:
|
||||
from_attributes = True
|
||||
model_config = ConfigDict(from_attributes=True)
|
||||
|
||||
|
||||
class PaginatedTicketsResponse(BaseModel):
|
||||
items: List[TicketDetail]
|
||||
total: int
|
||||
|
||||
|
||||
def generate_ticket_number() -> str:
|
||||
"""Generate unique ticket number like ST-2024-001"""
|
||||
year = datetime.now().year
|
||||
year = datetime.now(timezone.utc).year
|
||||
random_suffix = secrets.token_hex(2).upper()
|
||||
return f"ST-{year}-{random_suffix}"
|
||||
|
||||
@@ -129,7 +135,7 @@ async def create_support_ticket(
|
||||
ip_address=client_ip,
|
||||
user_id=current_user.id if current_user else None,
|
||||
status=TicketStatus.OPEN,
|
||||
created_at=datetime.utcnow()
|
||||
created_at=datetime.now(timezone.utc)
|
||||
)
|
||||
|
||||
db.add(new_ticket)
|
||||
@@ -158,14 +164,18 @@ async def create_support_ticket(
|
||||
}
|
||||
|
||||
|
||||
@router.get("/tickets", response_model=List[TicketDetail])
|
||||
@router.get("/tickets", response_model=List[TicketDetail] | PaginatedTicketsResponse)
|
||||
async def list_tickets(
|
||||
status: Optional[TicketStatus] = None,
|
||||
priority: Optional[TicketPriority] = None,
|
||||
category: Optional[TicketCategory] = None,
|
||||
assigned_to_me: bool = False,
|
||||
skip: int = 0,
|
||||
limit: int = 50,
|
||||
status: Optional[TicketStatus] = Query(None, description="Filter by ticket status"),
|
||||
priority: Optional[TicketPriority] = Query(None, description="Filter by ticket priority"),
|
||||
category: Optional[TicketCategory] = Query(None, description="Filter by ticket category"),
|
||||
assigned_to_me: bool = Query(False, description="Only include tickets assigned to the current admin"),
|
||||
search: Optional[str] = Query(None, description="Tokenized search across number, subject, description, contact name/email, current page, and IP"),
|
||||
skip: int = Query(0, ge=0, description="Offset for pagination"),
|
||||
limit: int = Query(50, ge=1, le=200, description="Page size"),
|
||||
sort_by: Optional[str] = Query(None, description="Sort by: created, updated, resolved, priority, status, subject"),
|
||||
sort_dir: Optional[str] = Query("desc", description="Sort direction: asc or desc"),
|
||||
include_total: bool = Query(False, description="When true, returns {items, total} instead of a plain list"),
|
||||
db: Session = Depends(get_db),
|
||||
current_user: User = Depends(get_admin_user)
|
||||
):
|
||||
@@ -186,8 +196,38 @@ async def list_tickets(
|
||||
query = query.filter(SupportTicket.category == category)
|
||||
if assigned_to_me:
|
||||
query = query.filter(SupportTicket.assigned_to == current_user.id)
|
||||
|
||||
tickets = query.order_by(desc(SupportTicket.created_at)).offset(skip).limit(limit).all()
|
||||
|
||||
# Search across key text fields
|
||||
if search:
|
||||
tokens = build_query_tokens(search)
|
||||
filter_expr = tokenized_ilike_filter(tokens, [
|
||||
SupportTicket.ticket_number,
|
||||
SupportTicket.subject,
|
||||
SupportTicket.description,
|
||||
SupportTicket.contact_name,
|
||||
SupportTicket.contact_email,
|
||||
SupportTicket.current_page,
|
||||
SupportTicket.ip_address,
|
||||
])
|
||||
if filter_expr is not None:
|
||||
query = query.filter(filter_expr)
|
||||
|
||||
# Sorting (whitelisted)
|
||||
query = apply_sorting(
|
||||
query,
|
||||
sort_by,
|
||||
sort_dir,
|
||||
allowed={
|
||||
"created": [SupportTicket.created_at],
|
||||
"updated": [SupportTicket.updated_at],
|
||||
"resolved": [SupportTicket.resolved_at],
|
||||
"priority": [SupportTicket.priority],
|
||||
"status": [SupportTicket.status],
|
||||
"subject": [SupportTicket.subject],
|
||||
},
|
||||
)
|
||||
|
||||
tickets, total = paginate_with_total(query, skip, limit, include_total)
|
||||
|
||||
# Format response
|
||||
result = []
|
||||
@@ -226,6 +266,8 @@ async def list_tickets(
|
||||
}
|
||||
result.append(ticket_dict)
|
||||
|
||||
if include_total:
|
||||
return {"items": result, "total": total or 0}
|
||||
return result
|
||||
|
||||
|
||||
@@ -312,10 +354,10 @@ async def update_ticket(
|
||||
|
||||
# Set resolved timestamp if status changed to resolved
|
||||
if ticket_data.status == TicketStatus.RESOLVED and ticket.resolved_at is None:
|
||||
ticket.resolved_at = datetime.utcnow()
|
||||
ticket.resolved_at = datetime.now(timezone.utc)
|
||||
changes["resolved_at"] = {"from": None, "to": ticket.resolved_at}
|
||||
|
||||
ticket.updated_at = datetime.utcnow()
|
||||
ticket.updated_at = datetime.now(timezone.utc)
|
||||
db.commit()
|
||||
|
||||
# Audit logging (non-blocking)
|
||||
@@ -358,13 +400,13 @@ async def add_response(
|
||||
message=response_data.message,
|
||||
is_internal=response_data.is_internal,
|
||||
user_id=current_user.id,
|
||||
created_at=datetime.utcnow()
|
||||
created_at=datetime.now(timezone.utc)
|
||||
)
|
||||
|
||||
db.add(response)
|
||||
|
||||
# Update ticket timestamp
|
||||
ticket.updated_at = datetime.utcnow()
|
||||
ticket.updated_at = datetime.now(timezone.utc)
|
||||
|
||||
db.commit()
|
||||
db.refresh(response)
|
||||
@@ -386,11 +428,15 @@ async def add_response(
|
||||
return {"message": "Response added successfully", "response_id": response.id}
|
||||
|
||||
|
||||
@router.get("/my-tickets", response_model=List[TicketDetail])
|
||||
@router.get("/my-tickets", response_model=List[TicketDetail] | PaginatedTicketsResponse)
|
||||
async def get_my_tickets(
|
||||
status: Optional[TicketStatus] = None,
|
||||
skip: int = 0,
|
||||
limit: int = 20,
|
||||
status: Optional[TicketStatus] = Query(None, description="Filter by ticket status"),
|
||||
search: Optional[str] = Query(None, description="Tokenized search across number, subject, description"),
|
||||
skip: int = Query(0, ge=0, description="Offset for pagination"),
|
||||
limit: int = Query(20, ge=1, le=200, description="Page size"),
|
||||
sort_by: Optional[str] = Query(None, description="Sort by: created, updated, resolved, priority, status, subject"),
|
||||
sort_dir: Optional[str] = Query("desc", description="Sort direction: asc or desc"),
|
||||
include_total: bool = Query(False, description="When true, returns {items, total} instead of a plain list"),
|
||||
db: Session = Depends(get_db),
|
||||
current_user: User = Depends(get_current_user)
|
||||
):
|
||||
@@ -403,7 +449,33 @@ async def get_my_tickets(
|
||||
if status:
|
||||
query = query.filter(SupportTicket.status == status)
|
||||
|
||||
tickets = query.order_by(desc(SupportTicket.created_at)).offset(skip).limit(limit).all()
|
||||
# Search within user's tickets
|
||||
if search:
|
||||
tokens = build_query_tokens(search)
|
||||
filter_expr = tokenized_ilike_filter(tokens, [
|
||||
SupportTicket.ticket_number,
|
||||
SupportTicket.subject,
|
||||
SupportTicket.description,
|
||||
])
|
||||
if filter_expr is not None:
|
||||
query = query.filter(filter_expr)
|
||||
|
||||
# Sorting (whitelisted)
|
||||
query = apply_sorting(
|
||||
query,
|
||||
sort_by,
|
||||
sort_dir,
|
||||
allowed={
|
||||
"created": [SupportTicket.created_at],
|
||||
"updated": [SupportTicket.updated_at],
|
||||
"resolved": [SupportTicket.resolved_at],
|
||||
"priority": [SupportTicket.priority],
|
||||
"status": [SupportTicket.status],
|
||||
"subject": [SupportTicket.subject],
|
||||
},
|
||||
)
|
||||
|
||||
tickets, total = paginate_with_total(query, skip, limit, include_total)
|
||||
|
||||
# Format response (exclude internal responses for regular users)
|
||||
result = []
|
||||
@@ -442,6 +514,8 @@ async def get_my_tickets(
|
||||
}
|
||||
result.append(ticket_dict)
|
||||
|
||||
if include_total:
|
||||
return {"items": result, "total": total or 0}
|
||||
return result
|
||||
|
||||
|
||||
@@ -473,7 +547,7 @@ async def get_ticket_stats(
|
||||
|
||||
# Recent tickets (last 7 days)
|
||||
from datetime import timedelta
|
||||
week_ago = datetime.utcnow() - timedelta(days=7)
|
||||
week_ago = datetime.now(timezone.utc) - timedelta(days=7)
|
||||
recent_tickets = db.query(func.count(SupportTicket.id)).filter(
|
||||
SupportTicket.created_at >= week_ago
|
||||
).scalar()
|
||||
|
||||
Reference in New Issue
Block a user